[OpenSMTPD] portable snapshot opensmtpd-201410131657p1 available

[g***@public.gmane.org]

A new opensmtpd portable snapshot is available at:

http://www.opensmtpd.org/archives/opensmtpd-201410131657p1.tar.gz

Checksum:

SHA256 (opensmtpd-201410131657p1.tar.gz) =
3f8749958c52d125697b8e6fbe4543fee325bdea64869352124ab3d59555b3c9

A summary of the content of this snapshot is available below.

Please test and let us know if it breaks something!

If this snapshot doesn't work, please also test with a previous one,
to help us spot where the issue is coming from. You can access all
previous snapshots here:

http://www.opensmtpd.org/archives/

The OpenSMTPD team ;-)


Summary of changes since last snapshot (opensmtpd-201410040019p1):
-----------------------------------------------------------------

- last known msgbuf_write vs EOF fix [1]
- use errc() to report correct error [2]
- use getlogin() to determine real user name where possible
- add missing errno
- fix a typo in trace options [3]
- use env->sc_hostname when refering to local host
- import simple rfc2822 parser
- import simple rfc822 parser
- iobuf_queue should return length, not 0 on success
- all headers and data lines now pass through rfc2822 parser
- strip Bcc headers
- rewrite From, To and Cc headers to append domain if none
- portable: errc() needs compat glue

[1] Author: krw@
[2] Author: Doug Hogan
[3] Author: Renaud Allard <renaud-***@public.gmane.org>

[Gilles Chehade]

Post by g***@public.gmane.org
- import simple rfc2822 parser
- import simple rfc822 parser
- all headers and data lines now pass through rfc2822 parser
- strip Bcc headers
- rewrite From, To and Cc headers to append domain if none

This part is kind of tricky and touchy.

Long story short, unless we parse From, To and Cc headers to append the
local domain when missing during an enqueue, then upon relaying to some
other MTA's _they_ will append their local domain with strange results.

Of course, this only happens when the client does not provide a domain,
which most clients do.

So I wrote a very tiny RFC2822 parser to parse the message, then a very
tiny RFC822 parser to extract addresses from some specific headers. The
parsers are not RFC complete but we don't really care, the goal is just
to catch the simple addresses sent by broken MUA's, anything we fail to
parse will simply result in the header being output unmodified.

PLEASE TEST HEAVILY. PLEASE TEST HEAVILY. PLEASE TEST HEAVILY.
PLEASE TEST HEAVILY. PLEASE TEST HEAVILY. PLEASE TEST HEAVILY.
PLEASE TEST HEAVILY. PLEASE TEST HEAVILY.

Oh, and please do test heavily.

[Gilles Chehade]

Post by g***@public.gmane.org
- import simple rfc2822 parser
- import simple rfc822 parser
- all headers and data lines now pass through rfc2822 parser
- strip Bcc headers
- rewrite From, To and Cc headers to append domain if none

Erf, the most important part ...

Please do test with different MUA's and report if the mails you send and
receive come up with weird From, To and Cc fields.

The parser is supposed to recognizes the following formats (all mixed):

To: gilles, eric,
gilles <gilles>,
eric faurot <eric>,
"charles longeau" <chl>


Which should result in a rewrite to:

To: gilles-***@public.gmane.org, eric-***@public.gmane.org,
gilles <gilles-***@public.gmane.org>,
eric faurot <eric-***@public.gmane.org>,
"charles longeau" <chl-***@public.gmane.org>

on my machine.

[Gilles Chehade]

Post by Gilles Chehade
Erf, the most important part ...
Please do test with different MUA's and report if the mails you send and
receive come up with weird From, To and Cc fields.
To: gilles, eric,
gilles <gilles>,
eric faurot <eric>,
"charles longeau" <chl>
on my machine.

I have received 0 feedback so far :-(

This needs to be part of our next release.

[Barbier, Jason]

So far in my limited testing it seems to work well with the way exchange
likes to drop addresses "Jason Barbier (Xtreme Consulting Group)" <

Post by Gilles Chehade

Post by Gilles Chehade
Erf, the most important part ...
Please do test with different MUA's and report if the mails you send and
receive come up with weird From, To and Cc fields.
To: gilles, eric,
gilles <gilles>,
eric faurot <eric>,
"charles longeau" <chl>
on my machine.

I have received 0 feedback so far :-(
This needs to be part of our next release.
--
Gilles Chehade
--

[Duncan Patton a Campbell]

On Tue, 14 Oct 2014 20:43:23 +0200

Post by Gilles Chehade

Post by Gilles Chehade
Erf, the most important part ...
Please do test with different MUA's and report if the mails you send and
receive come up with weird From, To and Cc fields.
To: gilles, eric,
gilles <gilles>,
eric faurot <eric>,
"charles longeau" <chl>
on my machine.

I have received 0 feedback so far :-(

Ok. I fetch www.opensmtpd.org/archives/opensmtpd-201410152134.tar.gz onto
[***@email:/usr/local/stars] # uname -a
OpenBSD email.indx.ca 5.5 GENERIC#0 i386
# patched up to 010_openssl

untar xfz it to opensmtpd-201410152134

I cd to opensmtpd-201410152134 and look at the README.md.

There's no opensmtpd to cd to so as to type ./configure which isn't in any subdirs either.

So I take a guess and cd to smtpd and

make

===> smtpd
cc -O2 -pipe -I/home/stars/opensmtpd-201410152134/smtpd/smtpd/../asr -g3 -ggdb -I/home/stars/opensmtpd-201410152134/smtpd/smtpd/.. -Wall -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations -Wshadow -Wpointer-arith -Wcast-qual -Wsign-compare -Wbounded -DIO_SSL -DQUEUE_PROFILING -c /home/stars/opensmtpd-201410152134/smtpd/smtpd/../aliases.c
...

===> smtpctl
...
cc -o smtpctl enqueue.o parser.o log.o envelope.o crypto.o queue_backend.o queue_fs.o smtpctl.o util.o compress_backend.o compress_gzip.o to.o expand.o tree.o dict.o reallocarray.o -lutil -lz -lcrypto
enqueue.o(.text+0x172c): In function `enqueue':
/home/stars/opensmtpd-201410152134/smtpd/smtpctl/../enqueue.c:297: undefined reference to `errc'
collect2: ld returned 1 exit status
*** Error 1 in smtpctl (<bsd.prog.mk>:95 'smtpctl')
*** Error 1 in /home/stars/opensmtpd-201410152134/smtpd (<bsd.subdir.mk>:48 'all')
[***@email:/usr/local/stars/opensmtpd-201410152134/smtpd] #

So I'm not entirely sure I did what I should do but ...

Dhu

Post by Gilles Chehade
This needs to be part of our next release.
--
Gilles Chehade
--